Re: [HACKERS] Logical replication: stuck spinlock atReplicationSlotRelease - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [HACKERS] Logical replication: stuck spinlock atReplicationSlotRelease
Date
Msg-id c252108d-5652-b5fd-4ec2-7dbfb92866bb@2ndquadrant.com
Whole thread Raw
In response to Re: [HACKERS] Logical replication: stuck spinlock atReplicationSlotRelease  (Andres Freund <andres@anarazel.de>)
Responses Re: [HACKERS] Logical replication: stuck spinlock at ReplicationSlotRelease
Re: [HACKERS] Logical replication: stuck spinlock atReplicationSlotRelease
List pgsql-hackers
On 6/23/17 16:15, Andres Freund wrote:
> On 2017-06-23 13:26:58 -0400, Alvaro Herrera wrote:
>> Hmm, so for instance in LogicalIncreaseRestartDecodingForSlot() we have
>> some elog(DEBUG1) calls with the slot spinlock held.  That's probably
>> uncool.
> 
> It definitely is not cool, rather daft even (it's probably me who wrote
> that).  No idea why I've done it like that, makes no sense.

Do you want to take a look at move those elog calls around a bit?  That
should do it.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: [HACKERS] pg_terminate_backend can terminate background workersand autovacuum launchers
Next
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] Get stuck when dropping a subscription duringsynchronizing table