Re: pg17.3 PQescapeIdentifier() ignores len - Mailing list pgsql-hackers

From Andres Freund
Subject Re: pg17.3 PQescapeIdentifier() ignores len
Date
Msg-id bukicrp3akqomk7lf6ywa7faxhxdnlcxnwfqx7tyeylemps2qi@gfrmkafkmcjx
Whole thread Raw
In response to Re: pg17.3 PQescapeIdentifier() ignores len  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pg17.3 PQescapeIdentifier() ignores len
List pgsql-hackers
Hi,

On 2025-02-13 14:00:09 -0500, Tom Lane wrote:
> Justin Pryzby <pryzby@telsasoft.com> writes:
> > The fprintf suggests that since 5dc1e42b4 PQescapeIdentifier ignores its len.
> 
> Ugh, yes.  Need something like the attached.

I just pushed this fix, together with an expansion of test_escape.c. With the
expanded test both uses of strlen() are detected.


> FTR, 5dc1e42b4 et al were quite subtle patches done under extreme time
> pressure.  I wonder if they have any other issues. More eyes on those
> patches would be welcome, now that they are public.

Indeed.

Greetings,

Andres Freund



pgsql-hackers by date:

Previous
From: Melanie Plageman
Date:
Subject: Re: Confine vacuum skip logic to lazy_scan_skip
Next
From: Thomas Munro
Date:
Subject: Re: Confine vacuum skip logic to lazy_scan_skip