Re: [HACKERS] Logical Replication and Character encoding - Mailing list pgsql-hackers

From Petr Jelinek
Subject Re: [HACKERS] Logical Replication and Character encoding
Date
Msg-id b8292d73-4d98-7663-26ef-c8f5569a3da9@2ndquadrant.com
Whole thread Raw
In response to Re: [HACKERS] Logical Replication and Character encoding  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: [HACKERS] Logical Replication and Character encoding  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
On 03/03/17 20:37, Peter Eisentraut wrote:
> On 2/27/17 00:23, Kyotaro HORIGUCHI wrote:
>> Yeah, the patch sends converted string with the length of the
>> orignal length. Usually encoding conversion changes the length of
>> a string. I doubt that the reverse case was working correctly.
> 
> I think we shouldn't send the length value at all.  This might have been
> a leftover from an earlier version of the patch.
> 
> See attached patch that removes the length value.
> 

Well the length is necessary to be able to add binary format support in
future so it's definitely not an omission.

--  Petr Jelinek                  http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training &
Services



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: [HACKERS] GUC for cleanup indexes threshold.
Next
From: Magnus Hagander
Date:
Subject: Re: [HACKERS] RADIUS fallback servers