Re: [HACKERS] objsubid vs subobjid - Mailing list pgsql-hackers

From Jim Nasby
Subject Re: [HACKERS] objsubid vs subobjid
Date
Msg-id b78a075e-784e-da4b-bd94-01ea410fcf52@openscg.com
Whole thread Raw
In response to Re: [HACKERS] objsubid vs subobjid  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
On 3/1/17 9:24 AM, Peter Eisentraut wrote:
> On 3/1/17 09:51, Alvaro Herrera wrote:
>> Peter Eisentraut wrote:
>>> On 2/22/17 19:35, Jim Nasby wrote:
>>>> pg_get_object_address() currently returns a field called subobjid, while
>>>> pg_depend calls that objsubid. I'm guessing that wasn't on purpose
>>>> (especially because internally the function uses objsubid), and it'd be
>>>> nice to fix it.
>>>
>>> I'm in favor of changing it, but it could theoretically break someone's
>>> code.
>>
>> Yes, it was an oversight.  +1 for changing.
>
> OK done.

BTW, did you backpatch as well? The function was added in 9.5. 
Presumably we wouldn't normally do that, but if we think this is unused 
enough maybe it's worth it.
-- 
Jim Nasby, Chief Data Architect, OpenSCG



pgsql-hackers by date:

Previous
From: Jim Nasby
Date:
Subject: Re: [HACKERS] Faster methods for getting SPI results (460%improvement)
Next
From: Jim Nasby
Date:
Subject: Re: [HACKERS] Change in "policy" on dump ordering?