On 27/08/2018 10:53, Fabien COELHO wrote:
> There is a "make_parsestate", but no corresponding free. The usual
> pattern, although there seems to be a few exception, is to "make" and
> "free".
>
> Even if there is some under-the-hood garbage collection, I'd suggest to
> add a free after the call to ComputePartitionAttrs.
Hmm, I didn't know about free_parsestate(). It doesn't seem to be used
consistently. I suppose you'll want to use it when you have a target
relation that will be closed by it, but otherwise, for DDL commands,
it's not all that useful.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
