Re: pg_rewind copies - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: pg_rewind copies
Date
Msg-id b2ebc855-61e3-818b-d6b8-cddf3e3d8816@iki.fi
Whole thread Raw
In response to Re: pg_rewind copies  (Cary Huang <cary.huang@highgo.ca>)
Responses Re: pg_rewind copies  (David Steele <david@pgmasters.net>)
List pgsql-hackers
On 16/12/2020 00:08, Cary Huang wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world:  tested, passed
> Implements feature:       tested, passed
> Spec compliant:           tested, passed
> Documentation:            not tested
> 
> Hello
> 
> The patch seems to do as described and the regression and tap tests are passing
> +    /*
> +     * A local source is not expected to change while we're rewinding, so check
> +     * that we size of the file matches our earlier expectation.
> +     */
> Is this a tyoo?

Yep, thanks! Attached is a new patch version, with that fixed and 
rebased. No other changes.

- Heikki

Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: LogwrtResult contended spinlock
Next
From: 'Alvaro Herrera'
Date:
Subject: Re: libpq debug log