Re: pg_rewind copies - Mailing list pgsql-hackers

From David Steele
Subject Re: pg_rewind copies
Date
Msg-id 171fd136-d523-57fd-6f03-26eea9427136@pgmasters.net
Whole thread Raw
In response to Re: pg_rewind copies  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: pg_rewind copies  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
On 1/22/21 8:26 AM, Heikki Linnakangas wrote:
> On 16/12/2020 00:08, Cary Huang wrote:
>> The following review has been posted through the commitfest application:
>> make installcheck-world:  tested, passed
>> Implements feature:       tested, passed
>> Spec compliant:           tested, passed
>> Documentation:            not tested
>>
>> Hello
>>
>> The patch seems to do as described and the regression and tap tests 
>> are passing
>> +    /*
>> +     * A local source is not expected to change while we're 
>> rewinding, so check
>> +     * that we size of the file matches our earlier expectation.
>> +     */
>> Is this a tyoo?
> 
> Yep, thanks! Attached is a new patch version, with that fixed and 
> rebased. No other changes.

Cary, does this patch look ready to commit? If so, please change the 
state in the CF entry to "Ready for Committer".

Regards,
-- 
-David
david@pgmasters.net



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Refactor SSL test framework to support multiple TLS libraries
Next
From: Dean Rasheed
Date:
Subject: Re: PoC/WIP: Extended statistics on expressions