Request a Demo
Home   >   mailing lists

Re: Persist slot invalidations before publishing them - Mailing list pgsql-hackers

From Bertrand Drouvot
Subject Re: Persist slot invalidations before publishing them
Date
Msg-id arz+Qy4Q+9wMtmJo@bdtpg
Whole thread
In response to Re: Persist slot invalidations before publishing them  (shveta malik <shveta.malik@gmail.com>)
List pgsql-hackers
Tree view 
Hi,

On Wed, Sep 30, 2026 at 09:08:41AM +0530, shveta malik wrote:
> On Tue, Sep 29, 2026 at 1:59 PM Bertrand Drouvot
> <bertranddrouvot.pg@gmail.com> wrote:
> >
> > The static flag looks safe, but I wonder if it wouldn't be clearer to keep
> > ReplicationSlotReleaseInternal() and call it with false from the error path?
> >
> > That would still allow us to remove update_inactive_since from
> > ReplicationSlotPersistInvalidation() and its callers, while keeping the
> > exceptional release behavior explicit.
> >
> 
> Okay, works for me.

Thanks, done that way in the attached.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
Attachment

pgsql-hackers by date:

Previous
From: Ashutosh Sharma
Date:
Subject: Re: remote_apply commit hangs when wal_receiver_status_interval = 0
Next
From: Daniel Gustafsson
Date:
Subject: Re: Do we need to back-patch tzcode 2026b after all?