Re: Add starelid, attnum to pg_stats and leverage this in pg_dump - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Add starelid, attnum to pg_stats and leverage this in pg_dump
Date
Msg-id apdDpCj4zdw9vPPF@nathan
Whole thread
In response to Re: Add starelid, attnum to pg_stats and leverage this in pg_dump  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Clear base backup progress reporting on error
List pgsql-hackers
On Mon, Aug 31, 2026 at 02:33:40PM +0900, Michael Paquier wrote:
> On Sun, Aug 30, 2026 at 07:21:07PM -0500, Sami Imseih wrote:
>>> Claude advises me that removing the redundant filter clause was a mistake.
>>> See the attached patch.
>> 
>> Yes, that was a miss. I did a quick confirmation of the execution plans
>> with and without the patch and the change LGTM.
> 
> The extra time taken would really hurt when retrieving statistics.
> There may be an argument in simply reverting 4b5ba0c4ca52, as one of
> the reasons for it was to remove the qual you are re-adding, but I
> cannot get excited about using two sets of catalog names for tablename
> and spcname vs a single OID array approach in the long run.

Committed, thanks for reviewing.

-- 
nathan



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: REPACK (CONCURRENTLY) fails when replica identity index is dropped
Next
From: Peter Smith
Date:
Subject: Re: Include sequences in publications created by pg_createsubscriber