Re: Add starelid, attnum to pg_stats and leverage this in pg_dump - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Add starelid, attnum to pg_stats and leverage this in pg_dump
Date
Msg-id apUSNL7IJIGYbNDl@paquier.xyz
Whole thread
In response to Re: Add starelid, attnum to pg_stats and leverage this in pg_dump  (Nathan Bossart <nathandbossart@gmail.com>)
Responses Re: SQL/JSON: JSON_TRANSFORM (SQL standard, subclause 6.44)
Re: Add starelid, attnum to pg_stats and leverage this in pg_dump
List pgsql-hackers
On Sun, Aug 30, 2026 at 07:21:07PM -0500, Sami Imseih wrote:
>> Claude advises me that removing the redundant filter clause was a mistake.
>> See the attached patch.
>
> Yes, that was a miss. I did a quick confirmation of the execution plans
> with and without the patch and the change LGTM.

The extra time taken would really hurt when retrieving statistics.
There may be an argument in simply reverting 4b5ba0c4ca52, as one of
the reasons for it was to remove the qual you are re-adding, but I
cannot get excited about using two sets of catalog names for tablename
and spcname vs a single OID array approach in the long run.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: [PATCH] Release replication slot on error in SQL-callable slot functions
Next
From: Amit Langote
Date:
Subject: Re: PG19 FK fast path: OOB write and missed FK checks during batched