Request a Demo
Home   >   mailing lists

Re: basebackup: do not verify checksums on pages written before enabling checksums - Mailing list pgsql-hackers

From Bertrand Drouvot
Subject Re: basebackup: do not verify checksums on pages written before enabling checksums
Date
Msg-id aoPdLUrm8D8+mvDN@bdtpg
Whole thread
In response to Re: basebackup: do not verify checksums on pages written before enabling checksums  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
Tree view 
Hi,

On Mon, Aug 17, 2026 at 04:06:09PM +0200, Daniel Gustafsson wrote:
> > On 17 Aug 2026, at 14:52, Zsolt Parragi <zsolt.parragi@percona.com> wrote:
> 
> > I improved the tests a bit, while also adding the 32m shared buffers
> 
> Thanks.  I've squashed these patches and added PG_TEST_EXTRA gates as well as a
> note in the base backup documentation about how checksum verification is
> impacted in case enabling is in progress.

Thanks! 

That looks good to me, just 1 nit comment:

=== 1

The test does not check that verification resumes while lastChecksumChangeRecPtr
is set. Just to be sure, did you skip that on purpose, or did you miss [1]?

[1]: https://postgr.es/m/aoMSMUUcNXJH4Djv%40bdtpg

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: Optimize UUID parse using SIMD
Next
From: Zsolt Parragi
Date:
Subject: Re: pg_stat_database.checksum_failures misses single-page failures in backups