Re: pg_stat_database.checksum_failures misses single-page failures in backups - Mailing list pgsql-hackers

From Zsolt Parragi
Subject Re: pg_stat_database.checksum_failures misses single-page failures in backups
Date
Msg-id CAN4CZFNJ1obgWiquL1jfJbD1zsG5fxY-dkE-gFfhXqEENfVz7w@mail.gmail.com
Whole thread
In response to Re: pg_stat_database.checksum_failures misses single-page failures in backups  (Nazir Bilal Yavuz <byavuz81@gmail.com>)
List pgsql-hackers
> I can track the original code change in the v5 posted here, which has
> been using a (> 1) for the sake of the plural message, at least that
> feels like the author's intention:

I read the intention there differently, as errmsg_plural has been
available since 2009.

> I would still just adjust the one-off in the if condition at the end.
> Reporting also a WARNING even if we have 1 checksum failure feels like
> the right thing to do.

I did that in v2, I also adjusted the total warning I mentioned earlier.

Attachment

pgsql-hackers by date:

Previous
From: Bertrand Drouvot
Date:
Subject: Re: basebackup: do not verify checksums on pages written before enabling checksums
Next
From: shveta malik
Date:
Subject: Re: A new C function `get_partition_root`.