Re: basebackup: do not verify checksums on pages written before enabling checksums - Mailing list pgsql-hackers

From Bertrand Drouvot
Subject Re: basebackup: do not verify checksums on pages written before enabling checksums
Date
Msg-id aoMGVEx9unsGenBV@bdtpg
Whole thread
In response to Re: basebackup: do not verify checksums on pages written before enabling checksums  (Bertrand Drouvot <bertranddrouvot.pg@gmail.com>)
Responses Re: [PATCH] ternary reloption type
Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f').
Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f').
List pgsql-hackers
Hi,

On Mon, Aug 17, 2026 at 03:36:03AM -0700, Zsolt Parragi wrote:
> > > but 010_backup_straddle.pl does not. Should 010_backup_straddle.pl also disable
> > > bgwriter to preserve dirty pages?
> >
> > I'm not sure, does it need to?
> 
> I think the test should be safe as-is, since we have more than enough
> shared buffers. Even with 32mb shared buffers, the test reliably
> errors out without the fix.

Couldn't the bgwriter still flush those dirty pages, regardless of the shared
buffers size? On a slower BF animal, the launcher may remain paused long enough
for additional bgwriter cycles to flush the pages. I'd still set
bgwriter_lru_maxpages = 0 to make the test more deterministic.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com



Attachment

pgsql-hackers by date:

Previous
From: Xuneng Zhou
Date:
Subject: Re: Implement waiting for wal lsn replay: reloaded
Next
From: Peter Eisentraut
Date:
Subject: Re: [PATCH] ternary reloption type