> I've updated the patch accordingly.
>
> I removed "is" from "RESPECT/IGNORE NULLS is specified" to match other
> similar error messages, which use the form "XXX specified, ...".
>
> + if (ignore_nulls != NO_NULLTREATMENT)
> + ereport(ERROR,
> + (errcode(ERRCODE_WRONG_OBJECT_TYPE),
The errcode field can start without a parenthesis:
errcode(ERRCODE_WRONG_OBJECT_TYPE),
Other than that the patch looks good to me.
Regards,
--
Tatsuo Ishii
SRA OSS K.K.
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
