Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f'). - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f').
Date
Msg-id CAHGQGwHOpAa5HyBvCHYxGGd1LLd37npn0mBxvosFY+w7f2Jgjw@mail.gmail.com
Whole thread
In response to Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f').  (Tatsuo Ishii <ishii@postgresql.org>)
List pgsql-hackers
On Thu, Jun 18, 2026 at 5:28 PM Tatsuo Ishii <ishii@postgresql.org> wrote:
>
> > I've updated the patch accordingly.
> >
> > I removed "is" from "RESPECT/IGNORE NULLS is specified" to match other
> > similar error messages, which use the form "XXX specified, ...".
> >
> > + if (ignore_nulls != NO_NULLTREATMENT)
> > + ereport(ERROR,
> > + (errcode(ERRCODE_WRONG_OBJECT_TYPE),
>
> The errcode field can start without a parenthesis:
>
> errcode(ERRCODE_WRONG_OBJECT_TYPE),

Yes, but other similar ereport() calls in parse_func.c also start
the errcode field with a parenthesis, so I followed the same style
here.

Regards,

--
Fujii Masao



pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f').
Next
From: Bruce Momjian
Date:
Subject: Re: [PATCH] Doc: document standard_conforming_strings dump/restore incompatibility