Re: Typo in pgbench messages. - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: Typo in pgbench messages.
Date
Msg-id alpine.DEB.2.22.394.2202251244220.2997974@pseudo
Whole thread Raw
In response to Re: Typo in pgbench messages.  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Typo in pgbench messages.  (Tatsuo Ishii <ishii@sraoss.co.jp>)
List pgsql-hackers
Hello Daniel,

>> I think that the break of typographical rules is intentional to allow 
>> such simplistic low-level stream handling through pipes or scripts. I'd 
>> prefer that the format is not changed. Maybe a comment could be added 
>> to explain the reason behind it.
>
> That doesn't sound like an overwhelmingly convincing argument to print 
> some messages with 'X %' and others with 'X%'.

Indeed. The no-space % are for database loading progress and the final 
report which I happen not to process through pipes and are more 
user-facing interfaces/reports. The stream piping need applies more to 
repeated lines such as those output by progress, which happen to avoid 
percentages anyway so the questions does not arise.

So fine with me wrt having a more homogeneous report.

-- 
Fabien.



pgsql-hackers by date:

Previous
From: Georgios
Date:
Subject: Add LZ4 compression in pg_dump
Next
From: Dean Rasheed
Date:
Subject: Re: Some optimisations for numeric division