Re: psql - add SHOW_ALL_RESULTS option - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: psql - add SHOW_ALL_RESULTS option
Date
Msg-id alpine.DEB.2.22.394.2201150938470.3378943@pseudo
Whole thread Raw
In response to Re: psql - add SHOW_ALL_RESULTS option  (Andres Freund <andres@anarazel.de>)
Responses Re: psql - add SHOW_ALL_RESULTS option
Re: psql - add SHOW_ALL_RESULTS option
List pgsql-hackers
Hello Andres,

> The reason this test constantly fails on cfbot windows is a use-after-free
> bug.

Indeed! Thanks a lot for the catch and the debug!

The ClearOrSaveResult function is quite annoying because it may or may not 
clear the result as a side effect.

Attached v14 moves the status extraction before the possible clear. I've 
added a couple of results = NULL after such calls in the code.

-- 
Fabien.
Attachment

pgsql-hackers by date:

Previous
From: Julien Rouhaud
Date:
Subject: Re: pg_replslotdata - a tool for displaying replication slot information
Next
From: Julien Rouhaud
Date:
Subject: Re: Avoid erroring out when unable to remove or parse logical rewrite files to save checkpoint work