Re: pgbench logging broken by time logic changes - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: pgbench logging broken by time logic changes
Date
Msg-id alpine.DEB.2.22.394.2107101127400.775110@pseudo
Whole thread Raw
In response to Re: pgbench logging broken by time logic changes  (Fabien COELHO <coelho@cri.ensmp.fr>)
Responses Re: pgbench logging broken by time logic changes  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
Hello again,

>> I hoped we were done here but I realised that your check for 1-3 log
>> lines will not survive the harsh environment of the build farm.
>> Adding sleep(2) before the final doLog() confirms that.  I had two
>> ideas:

>> So I think we should do 1 for now.  Objections or better ideas?
>
> At least, we now that it is too much.

I misread your point. You think that it should fail, but it is not
tried yet. I'm rather optimistic that it should not fail, but I'm okay 
with averting the risk anyway.

> What about moving the test as is in the TODO section with a comment, next to 
> the other one, for now?

I stand by this solution which should allow to get some data from the 
field, as v18 attached. If all is green then the TODO could be removed 
later.

-- 
Fabien.
Attachment

pgsql-hackers by date:

Previous
From: Erik Rijkers
Date:
Subject: Re: SQL/JSON: JSON_TABLE
Next
From: Dean Rasheed
Date:
Subject: Re: Enhanced error message to include hint messages for redundant options error