RE: psql - add SHOW_ALL_RESULTS option - Mailing list pgsql-hackers

From Fabien COELHO
Subject RE: psql - add SHOW_ALL_RESULTS option
Date
Msg-id alpine.DEB.2.22.394.2104071516470.2724014@pseudo
Whole thread Raw
In response to RE: psql - add SHOW_ALL_RESULTS option  ("shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>)
Responses RE: psql - add SHOW_ALL_RESULTS option  ("shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>)
List pgsql-hackers
Hello,

> I met a problem after commit 3a51306722.
>
> While executing  a SQL statement with psql,  I can't interrupt it by pressing ctrl+c.
>
> For example:
> postgres=# insert into test select generate_series(1,10000000);
> ^C^CINSERT 0 10000000
>
> Press ctrl+c before finishing INSERT, and psql still continuing to INSERT.

I can confirm this unexpected change of behavior on this commit. This is 
indeed e bug.

> Is it the result expected?

Obviously not.

> And I think maybe it is better to allow users to interrupt by pressing 
> ctrl+c.

Obviously yes.

The problem is that the cancellation stuff is cancelled too early after 
sending an asynchronous request.

Attached a patch which attempts to fix this by moving the cancellation 
cancelling request after processing results.

-- 
Fabien.
Attachment

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: [PATCH] Improve treatment of page special and page header alignment during page init.
Next
From: Andy Fan
Date:
Subject: Cost model improvement for run-time partition prune