Re: pgbench - extend initialization phase control - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: pgbench - extend initialization phase control
Date
Msg-id alpine.DEB.2.21.1911070914310.20647@lancre
Whole thread Raw
In response to Re: pgbench - extend initialization phase control  (btkimurayuzk <btkimurayuzk@oss.nttdata.com>)
Responses Re: pgbench - extend initialization phase control  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
>>> I think that it may break --no-vacuum, and I thought that there may be
>>> other option which remove things, eventually. Also, having a NO-OP looks
>>> ok to me.
>> 
>> As far as I read the code, checkInitSteps() checks the initialization
>> steps that users specified. The initialization steps string that
>> "v" was replaced with blank character is not given to checkInitSteps().
>> So ISTM that dropping the handling of blank character from
>> checkInitSteps() doesn't break --no-vacuum.
>> 
> This is a patch which does not allow space character in -I options .

I do not think that this is desirable. It would be a regression, and 
allowing a no-op is not an issue in anyway.

-- 
Fabien Coelho - CRI, MINES ParisTech



pgsql-hackers by date:

Previous
From: Julien Rouhaud
Date:
Subject: Re: Collation versioning
Next
From: Etsuro Fujita
Date:
Subject: Re: [PATCH][DOC] Fix for PREPARE TRANSACTION doc and postgres_fdw message.