Re: pgbench - allow to create partitioned tables - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: pgbench - allow to create partitioned tables
Date
Msg-id alpine.DEB.2.21.1909180921380.32172@lancre
Whole thread Raw
In response to Re: pgbench - allow to create partitioned tables  (Amit Langote <amitlangote09@gmail.com>)
Responses Re: pgbench - allow to create partitioned tables
List pgsql-hackers
Hello Amit,

> +                    fprintf(stderr, "invalid partition type,
> expecting \"range\" or \"hash\","
>
> How about "partitioning method" instead of "partition type"?

Indeed, this is a left over from a previous version.

> +            fprintf(stderr, "--partition-method requires actual
> partitioning with --partitions\n");
>
> [...] "--partition-method requires --partitions to be greater than zero"


I think the first suggestion is clear enough. I've put a shorter variant 
in the same spirit:

   "--partitions-method requires greater than zero --partitions"

Attached v10 fixes both messages.

-- 
Fabien.
Attachment

pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: Efficient output for integer types
Next
From: Michael Paquier
Date:
Subject: Re: Proposal: Add more compile-time asserts to exposeinconsistencies.