Re: Undocumented PQdisplayTuples and PQprintTuples in libpq - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: Undocumented PQdisplayTuples and PQprintTuples in libpq
Date
Msg-id alpine.DEB.2.21.1908050649420.16639@lancre
Whole thread Raw
In response to Undocumented PQdisplayTuples and PQprintTuples in libpq  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Undocumented PQdisplayTuples and PQprintTuples in libpq  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Bonjour Michaël,

> I have noticed today that the two functions in $subject are part of
> libpq and remain around undocumented since they are around (see
> 6ef5846 and 2b84cbb).  Isn't it past time to get rid of them?  We have
> PQprint as well, which was used in the past by psql but not today,
> still that's documented.  Note that the coverage in this area is a
> perfect 0%:
> https://coverage.postgresql.org/src/interfaces/libpq/fe-print.c.gcov.html

<sigh>

> I am also wondering how an update to exports.txt should be handled in
> this case.  Just by commenting out the numbers which are not used
> anymore?

How do you know that they are not used by anyone in the wild?
If they are broken, it would be a clue. If not, possibly someone somewhere 
could be using it, eg for debug (what does this result look like?).

-- 
Fabien.

pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: partition routing layering in nodeModifyTable.c
Next
From: yuzuko
Date:
Subject: Re: Problem with default partition pruning