Re: pgbench tests vs Windows - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: pgbench tests vs Windows
Date
Msg-id alpine.DEB.2.21.1907240729300.10384@lancre
Whole thread Raw
In response to pgbench tests vs Windows  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
Responses Re: pgbench tests vs Windows  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
List pgsql-hackers
Hello Andrew,

> Unfortunately, this isn't portable, as I've just discovered at the cost
> of quite a bit of time. In particular, you can't assume expr is present
> and in the path on Windows. The Windows equivalent would be something like:
>
>    \setshell two\
>      @set /a c = 1 + :one  && echo %c%

Hmmm... Can we assume that echo is really always there on Windows? If so, 
the attached patch does something only with "echo".

> I propose to prepare a patch along these lines. Alternatively we could
> just drop it - I don't think the test matters all that hugely.

The point is to have some minimal coverage so that unexpected changes are 
caught. This is the only call to a working \setshell.

-- 
Fabien.
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: On the stability of TAP tests for LDAP
Next
From: Fabien COELHO
Date:
Subject: Re: pgbench - allow to create partitioned tables