Re: [PATCH] Implement uuid_version() - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: [PATCH] Implement uuid_version()
Date
Msg-id alpine.DEB.2.21.1907130816430.8895@lancre
Whole thread Raw
In response to Re: [PATCH] Implement uuid_version()  (Jose Luis Tallon <jltallon@adv-solutions.net>)
Responses Re: [PATCH] Implement uuid_version()  (Jose Luis Tallon <jltallon@adv-solutions.net>)
List pgsql-hackers
Hello Jose,

> Got it, and done. Please find attached a v2 patch with the upgrade script 
> included.

Patch v2 applies cleanly. Compiles cleanly (once running configure 
--with-uuid=...). Local make check ok. Doc build ok.

There are no tests, I'd suggest to add some under sql & change expected if 
possible which would return all possible values, including with calling 
pg_random_uuid() which should return 4.

Documentation describes uuid_version(), should it not describe 
uuid_version(namespace uuid)?

I'd suggest to add an example.

The extension update script seems ok, but ISTM that "uuid-ossp-1.1.sql" 
should be replaced with an updated "uuid-ossp-1.2.sql".

-- 
Fabien.



pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Allow an alias to be attached directly to a JOIN ... USING
Next
From: Michael Paquier
Date:
Subject: Re: Comment fix of config_default.pl