RE: psql - add SHOW_ALL_RESULTS option - Mailing list pgsql-hackers

From Fabien COELHO
Subject RE: psql - add SHOW_ALL_RESULTS option
Date
Msg-id alpine.DEB.2.21.1904240654120.3407@lancre
Whole thread Raw
In response to RE: psql - add SHOW_ALL_RESULTS option  ("Iwata, Aya" <iwata.aya@jp.fujitsu.com>)
Responses RE: psql - add SHOW_ALL_RESULTS option
List pgsql-hackers
Hello Aya-san,

Thanks for this review.

> There is space (+--' '). Please delete it. It is cause of regression test failed.

Indeed, unsure how I could do that. Fixed.

>> IMHO this new setting should be on by default: few people know about \; so
>> it would not change anything for most, and I do not see why those who use
>> it would not be interested by the results of all the queries they asked for.
> I agree with your opinion.

Ok. I did not yet change the default in the attached version, though.

> I test some query combination case. And I found when warning happen, the 
> message is printed in head of results. I think it is not clear in which 
> query the warning occurred.

Indeed.

> How about print warning message before the query that warning occurred?

Sure. It happened to be trickier than I thought to achieve this, because 
there is a callback hook to send notifications.

This attached version does:
  - ensure that warnings appear just before its
  - add the entry in psql's help
  - redefine the function boundary so that timing is cleaner
  - include somehow improved tests

-- 
Fabien.
Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Segfault when restoring -Fd dump on current HEAD
Next
From: Justin Pryzby
Date:
Subject: Re: clean up docs for v12