Re: pgsql: Fix unportable code in pgbench. - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: pgsql: Fix unportable code in pgbench.
Date
Msg-id alpine.DEB.2.21.1904172339370.26370@lancre
Whole thread Raw
Responses Re: pgsql: Fix unportable code in pgbench.
List pgsql-hackers
Hello Tom,

> Fix unportable code in pgbench.

Sorry for this unforseen issue... portability is a pain:-(

> The buildfarm points out that UINT64_FORMAT might not work with sscanf;
> it's calibrated for our printf implementation, which might not agree
> with the platform-supplied sscanf.  Fall back to just accepting an
> unsigned long, which is already more than the documentation promises.

Yep, but ISTM that it is down to 32 bits, whereas the PRNG seed expects 48 
bits a few lines below:

     base_random_sequence.xseed[0] = iseed & 0xFFFF;
     base_random_sequence.xseed[1] = (iseed >> 16) & 0xFFFF;
     base_random_sequence.xseed[2] = (iseed >> 32) & 0xFFFF;

So the third short is now always 0. Hmmm. I'll propose another option over 
the week-end.

-- 
Fabien.



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: pg_dump is broken for partition tablespaces
Next
From: Tom Lane
Date:
Subject: Re: pg_dump is broken for partition tablespaces