Re: Patch to document base64 encoding - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: Patch to document base64 encoding
Date
Msg-id alpine.DEB.2.21.1903061913540.24790@lancre
Whole thread Raw
In response to Re: Patch to document base64 encoding  ("Karl O. Pinc" <kop@meme.com>)
Responses Re: Patch to document base64 encoding
List pgsql-hackers
> Attached: doc_base64_v7.patch

Patch applies cleanly, doc compiles, navigation tested and ok.

"... section 6.8" -> "... Section 6.8" (capital S).

"The string and the binary encode and decode functions..." sentence looks 
strange to me, especially with the English article that I do not really 
master, so maybe it is ok. I'd have written something more 
straightforward, eg: "Functions encode and decode support the following 
encodings:", and also I'd use a direct "Function <...>decode</...> ..." 
rather than "The <function>decode</function> function ..." (twice).

Maybe I'd use the exact same grammatical structure for all 3 cases, 
starting with "The <>whatever</> encoding converts bla bla bla" instead of 
varying the sentences.

Otherwise, all explanations look both precise and useful to me.

-- 
Fabien.


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: patch to allow disable of WAL recycling
Next
From: Jeremy Schneider
Date:
Subject: Re: Should we increase the default vacuum_cost_limit?