Re: fix psql \conninfo & \connect when using hostaddr - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: fix psql \conninfo & \connect when using hostaddr
Date
Msg-id alpine.DEB.2.21.1811171530020.16105@lancre
Whole thread Raw
In response to Re: fix psql \conninfo & \connect when using hostaddr  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: fix psql \conninfo & \connect when using hostaddr
List pgsql-hackers
On Sat, 17 Nov 2018, Alvaro Herrera wrote:

>> /* ----------
>>  * getHostaddr -
>>  * Fills 'host_addr' with the string representation of the currently connected
>>  * socket in 'conn'.
>>  * ----------
>>  */
>> static void
>> getHostaddr(PGconn *conn, char *host_addr, int host_addr_len)

> Fabien, are you planning to fix things per Arthur's review?

Yep, I am.

I will not do the above though, because the PQgetHostaddr API would differ 
from all other connection status functions (PQgetHost, PQgetUser...) which 
are all "char * PQget<Something>(PGconn * conn)"

-- 
Fabien.


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Accounting of zero-filled buffers in EXPLAIN (BUFFERS)
Next
From: Fabien COELHO
Date:
Subject: Re: fix psql \conninfo & \connect when using hostaddr