Re: libpq stricter integer parsing - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: libpq stricter integer parsing
Date
Msg-id alpine.DEB.2.21.1809071706210.26080@lancre
Whole thread Raw
In response to Re: libpq stricter integer parsing  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: libpq stricter integer parsing
List pgsql-hackers
Hello Peter,

>> The timeout is set to 2, and the port directive is silently ignored.
>> However, URL parsing is stricter, eg on "port".
>>
>> The attached patch checks integer syntax errors and overflows, and report
>> errors.
>
> This looks useful and the patch looks reasonable, but it doesn't apply
> anymore.  Can you send in an update?

Hmmm. It does apply on a test I just did right know...

Usually it does not apply with "git apply" if your MUA does not know that 
MIME requires CR LF eol on text files, and that it is its responsability 
to switch to something else if desired. Pg automatic patch checker does 
not know about that so complains unduly. Some MUA send attachements which 
violates MIME (text attachements with LF only eol), thus hidding the 
issue.

Otherwise, the "patch" command should work?

-- 
Fabien.


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Hint to set owner for tablespace directory
Next
From: Fabien COELHO
Date:
Subject: Re: Removing useless \. at the end of copy in pgbench