Re: doc - add missing documentation for "acldefault" - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: doc - add missing documentation for "acldefault"
Date
Msg-id alpine.DEB.2.21.1808031208310.8068@lancre
Whole thread Raw
In response to Re: doc - add missing documentation for "acldefault"  (Arthur Zakirov <a.zakirov@postgrespro.ru>)
List pgsql-hackers
>> postgres=# \df acl*
>> List of fun
>>    Schema   |    Name     | Result data type |
>> ------------+-------------+------------------+----------------------------------
>>  pg_catalog | aclcontains | boolean          | aclitem[], aclitem
>>  pg_catalog | acldefault  | aclitem[]        | "char", oid
>>  pg_catalog | aclexplode  | SETOF record     | acl aclitem[], OUT grantor
>> oid, O
>>  pg_catalog | aclinsert   | aclitem[]        | aclitem[], aclitem
>>  pg_catalog | aclitemeq   | boolean          | aclitem, aclitem
>>  pg_catalog | aclitemin   | aclitem          | cstring
>>  pg_catalog | aclitemout  | cstring          | aclitem
>>  pg_catalog | aclremove   | aclitem[]        | aclitem[], aclitem
>
> Some of them are definitely internal. For example, aclitemin and
> aclitemout are input and output functions respectively of the aclitem
> data type. I think they don't need to be documented and shouldn't have
> "pg_" prefix as they was created to maintenance aclitem data type.

Indeed, some are internal for managing the type itself. Maybe that 
encompasses also "aclitemeq", not sure. I would see no harm in having them 
documented though.

ISTM that acl{contains,default,explode,insert,remove} deserve a real doc.

-- 
Fabien.

pgsql-hackers by date:

Previous
From: Adrien NAYRAT
Date:
Subject: Re: Explain buffers wrong counter with parallel plans
Next
From: Robert Haas
Date:
Subject: Re: Alter index rename concurrently to