Re: pgbench: improve --help and --version parsing - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: pgbench: improve --help and --version parsing
Date
Msg-id alpine.DEB.2.21.1807230744330.3461@lancre
Whole thread Raw
In response to Re: pgbench: improve --help and --version parsing  (Michael Paquier <michael@paquier.xyz>)
Responses Re: pgbench: improve --help and --version parsing  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Hello Michaël,

>> I doubt that -V & -? are heavily tested:-) Patch works for me, though.
>
> They are not, and the patch misses this area.

Indeed.

> I don't think that it is a bad idea to improve things the way you are

For the record, this is not my patch, I'm merely reviewing it.

> doing, however you should extend program_version_ok() and 
> program_help_ok() in src/test/perl/TestLib.pm so as short options are 
> tested for two reasons:

Interesting, I did not notice these functions before. I fully agree that 
manual testing is a pain for such a simple change.

Do you mean something like the attached?

-- 
Fabien.
Attachment

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: ToDo: show size of partitioned table
Next
From: Simon Riggs
Date:
Subject: Re: [HACKERS] Two pass CheckDeadlock in contentent case