Postgres Pro
Downloads
Home   >   mailing lists

Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts
Date
Msg-id alpine.DEB.2.20.1803251252390.8109@lancre
Whole thread Raw
In response to Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts  ("Rady, Doug" <radydoug@amazon.com>)
Responses Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts  ("Rady, Doug" <radydoug@amazon.com>)
List pgsql-hackers
Tree view 
Hello Doug,

> Updated the patch to not do the #undef
> pgbench11-ppoll-v11.patch attached.

Patch applies. Do not forget to regenerate configure to test...

I've compiled and run with both ppoll & select options without issues.

Two quite minor style comment (at least 2 instances):

   if (cond) return false; else return true;

ISTM that the simpler the better:

   return !cond;

Also ISTM that the following does not comply with pg C style expectations 
(idem, 2 instances):

   } else {


-- 
Fabien.

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: ALTER TABLE ADD COLUMN fast default
Next
From: Haribabu Kommi
Date:
Subject: Re: PQHost() undefined behavior if connecting string contains bothhost and hostaddr types