Re: pgbench - add \if support - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: pgbench - add \if support
Date
Msg-id alpine.DEB.2.20.1803011107190.7903@lancre
Whole thread Raw
In response to Re: pgbench - add \if support  (Andres Freund <andres@anarazel.de>)
Responses Re: pgbench - add \if support  ("Daniel Verite" <daniel@manitou-mail.org>)
List pgsql-hackers
Hello Andres,

>> Here is a very minor rebase.
>
> Your recent patches all seem to have windows line-endings.

There does not seem to be any on my side:

   sh> hexdump pgbench-if-6.patch | grep '0[ad]' | head -3
     0000040 6562 636e 2e68 6773 6c6d 690a 646e 7865
     0000060 2031 3031 3630 3434 2d0a 2d2d 6120 642f
     0000080 6770 6562 636e 2e68 6773 6c6d 2b0a 2b2b

There are a few LF (0a) but no CR (0d) visible.

I'd guess that you are running on windows, that the mime-type of the 
attachement is "text/x-diff", which is what my ubuntu box lists as 
appropriate for "*.patch", and that because of "text/" your mail client 
would have decided to switch "\n" to "\r\n" on its own?

> It'd be good to fix that for the future...

What should I do about transformations on the receiving side?

-- 
Fabien.


pgsql-hackers by date:

Previous
From: Nikita Glukhov
Date:
Subject: Re: Cast jsonb to numeric, int, float, bool
Next
From: Andres Freund
Date:
Subject: Re: TAP test module - PostgresClient