Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] pgbench - refactor some connection finish/null intocommon function - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: [PATCH] pgbench - refactor some connection finish/null intocommon function
Date
Msg-id alpine.DEB.2.20.1801301233220.22080@lancre
Whole thread Raw
In response to [PATCH] pgbench - refactor some connection finish/null into commonfunction  ("Rady, Doug" <radydoug@amazon.com>)
Responses Re: [PATCH] pgbench - refactor some connection finish/null intocommon function
List pgsql-hackers
Tree view 
Hello Doug,

> This patch refactors all of the connection state PQfinish() and NULL’ing into a single function.
> Excludes PQfinish() in doConnect().

My 0.02€:

The argument could be "PGconn **" instead of a "CState *"?
If so, it may be used in a few more places. What is your opinion?

I'm fine with this kind of factorization which takes out a three-line 
pattern, but I'm wondering whether it would please committers.

-- 
Fabien.

pgsql-hackers by date:

Previous
From: Oliver Ford
Date:
Subject: Re: Add RANGE with values and exclusions clauses to the Window Functions
Next
From: Kyotaro HORIGUCHI
Date:
Subject: Re: [HACKERS] path toward faster partition pruning