Re: pgbench - add \if support - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: pgbench - add \if support
Date
Msg-id alpine.DEB.2.20.1801091403530.6718@lancre
Whole thread Raw
In response to Re: pgbench - add \if support  (Dmitry Dolgov <9erthalion6@gmail.com>)
List pgsql-hackers
Hello Dmitry,

>> What you are trying to do is the result of combining the pgbench-if patch
>> and the pgbench-more-ops-and-funcs patch.
>
> Oh, I see. I missed the first message about this patch, sorry. But for some
> reason I can't apply both patches (pgbench-more-ops-funcs-23.patch and
> pgbench-if-4.patch) in any order:

>    Hunk #24 FAILED at 2824. [...]

Indeed, they interfere.

> Is there any other dependency I should apply?

No, the patches really conflict in minor ways. They are expected to be 
reviewed independently. If/when one feature is committed, I('ll) update 
the remaining patches so that they still work.

If I produce dependent patches ISTM that it makes a more complicated 
review, so the patches are less likely to be reviewed and maybe finally 
committed.

I just wanted to point out that the the features are more interestings 
when combined than on their own.

-- 
Fabien.


pgsql-hackers by date:

Previous
From: Fabien COELHO
Date:
Subject: Re: Re: [HACKERS] pgbench randomness initialization
Next
From: Vik Fearing
Date:
Subject: Re: pgbench - add \if support