Re: [HACKERS] Confusing error message in pgbench - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: [HACKERS] Confusing error message in pgbench
Date
Msg-id alpine.DEB.2.20.1708021707350.3746@lancre
Whole thread Raw
In response to [HACKERS] Confusing error message in pgbench  (Tatsuo Ishii <ishii@sraoss.co.jp>)
List pgsql-hackers
Hello Tatsuo-san,

> I found an error message in pgbench is quite confusing.
>
> pgbench -S -M extended -c 1 -T 30 test
> query mode (-M) should be specified before any transaction scripts (-f or -b)
>
> Since there's no -f or -b option is specified, users will be
> confused.

Indeed.

> Actually the error occurs because pgbench implicitly introduces a built 
> in script for -S. To eliminate the confusion, I think the error message 
> should be fixed like this:

The idea is that -S/-N documentations say that it is just a shortcut for 
-b, but the explanation (eg --help) is too far away.

> query mode (-M) should be specified before transaction type (-S or -N) 
> or any transaction scripts (-f or -b)

I would suggest to make it even shorter, see attached:

query mode (-M) should be specified before any transaction scripts (-f, 
-b, -S or -N).

I'm wondering whether it could/should be "any transaction script". My 
English level does not allow to decide.

-- 
Fabien.
-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] Macros bundling RELKIND_* conditions
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] pgsql 10: hash indexes testing