Re: [HACKERS] Adding -E switch to pg_dumpall - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: [HACKERS] Adding -E switch to pg_dumpall
Date
Msg-id alpine.DEB.2.20.1707201106470.4496@lancre
Whole thread Raw
In response to Re: [HACKERS] Adding -E switch to pg_dumpall  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [HACKERS] Adding -E switch to pg_dumpall
List pgsql-hackers
Hello Michaël-san,

> Attached is a patch to add support for this switch. I am parking that
> in the next CF.

I'm in favor of this feature for consistency with pg_dump, and as the 
environment variable workaround is not specially elegant and can induce 
issues of its own.

Patch applies and compiles.

No special regression tests are provided, but this seems ok to me as it 
just forward the option to pg_dump, which I have no doubt is heavily 
tested. Or not. Anyway it is consistent...

Manually tested with UTF8, latin1 (including conversion errors), non 
existing.

Code is straightforward. Doc and help are both fine.

Ok for me. I switched the status to "Ready for committers".

-- 
Fabien.

pgsql-hackers by date:

Previous
From: Neha Sharma
Date:
Subject: Re: [HACKERS] [TRAP: FailedAssertion] causing server to crash
Next
From: Dmitry Dolgov
Date:
Subject: [HACKERS] Proposal about a "deep" versions for some jsonb functions