Re: [HACKERS] proposal: session server side variables - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: [HACKERS] proposal: session server side variables
Date
Msg-id alpine.DEB.2.20.1701041843000.22281@lancre
Whole thread Raw
In response to Re: [HACKERS] proposal: session server side variables  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: [HACKERS] proposal: session server side variables  (Pavel Stehule <pavel.stehule@gmail.com>)
Re: [HACKERS] proposal: session server side variables  (Craig Ringer <craig@2ndquadrant.com>)
List pgsql-hackers
> ok understand

Good. So we seem to agree that GUCS are transactional?

> The logic depends on transactions and on nesting level (nesting doesn't
> depends on transactions only)

Yep, it probably also happens with LOCAL which hides the previous value 
and restores the initial one when exiting.

> void AtEOXact_GUC(bool isCommit, int nestLevel)
>
> Probably we should to use CallXactCallbacks instead - then is not a
> performance impact when there are not transactional variables.

I do not understand your point.

It is a very good thing that GUCs are transactional, and this should not 
be changed, it is a useful feature! Much more useful than non 
transactional.

Moreover I think that transactional is expensive when writing things to 
disk, but in memory the overhead is reduced, and if you need it then you 
need it.

-- 
Fabien.



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: [HACKERS] Logical Replication WIP
Next
From: Pavel Stehule
Date:
Subject: Re: [HACKERS] proposal: session server side variables