Re: confusing checkpoint_flush_after / bgwriter_flush_after - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: confusing checkpoint_flush_after / bgwriter_flush_after
Date
Msg-id alpine.DEB.2.20.1611260735370.29326@lancre
Whole thread Raw
In response to Re: confusing checkpoint_flush_after / bgwriter_flush_after  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
>> Maybe something like the following, or maybe it should include "bufmgr.h",
>> not sure.
>
> As-is this patch seems like a maintenance time bomb; it really needs to
> use the #defines rather than have the values hard-wired in.  However, just
> including bufmgr.h in frontend code doesn't work, so I moved the #defines
> to pg_config_manual.h, which seems like a more reasonable place for them
> anyway. Pushed with that and some other polishing.

Indeed, that's much cleaner and easier to maintain. Thanks.

-- 
Fabien.



pgsql-hackers by date:

Previous
From: Jim Nasby
Date:
Subject: Re: References to arbitrary database objects that are suitable for pg_dump
Next
From: Amit Kapila
Date:
Subject: Re: Parallel Index Scans