Re: pgbench small bug fix - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: pgbench small bug fix
Date
Msg-id alpine.DEB.2.10.1603091005231.25393@sto
Whole thread Raw
In response to Re: pgbench small bug fix  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: pgbench small bug fix
List pgsql-hackers
> On Wed, Jan 27, 2016 at 2:31 PM, Fabien COELHO <coelho@cri.ensmp.fr> wrote:
>>  - when a duration (-T) is specified, ensure that pgbench ends at that
>>    time (i.e. do not wait for a transaction beyond the end of the run).
>
> Every other place where doCustom() returns false is implemented as
> return clientDone(...).  I think this should probably do the same.

Why not. clientDone() second arguments is totally ignored, I put true 
because it looks better.

> I also think that we should probably store the end time someplace
> instead of recomputing it in multiple places (this patch adds two such
> places).

Why not.

Attached is a v4.

-- 
Fabien.

pgsql-hackers by date:

Previous
From: Emre Hasegeli
Date:
Subject: Re: SP-GiST support for inet datatypes
Next
From: Alexander Korotkov
Date:
Subject: Re: WIP: Access method extendability