Re: pgbench stats per script & other stuff - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: pgbench stats per script & other stuff
Date
Msg-id alpine.DEB.2.10.1601271325140.12620@sto
Whole thread Raw
In response to Re: pgbench stats per script & other stuff  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: pgbench stats per script & other stuff
List pgsql-hackers
Hello again,

>> Obviously this would work. I did not think the special case was worth the
>> extra argument. This one has some oddity too, because the second argument is
>> ignored depending on the third. Do as you feel.
>
> Actually my question was whether keeping the original start_time was the
> intended design.

Sorry I misunderstood the question.

The answer is essentially yes, the field is needed for the "aggregated" 
mode where this specific behavior is used.

However, after some look at the code I think that it is possible to do 
without.

I also spotted an small issue under low tps where the last aggregation was 
not shown.

With the attached version these problems have been removed, no conditional 
initialization. There is also a small diff with the version you sent.

-- 
Fabien.

pgsql-hackers by date:

Previous
From: Jinhua Luo
Date:
Subject: Re: insert/update performance
Next
From: Dilip Kumar
Date:
Subject: Re: Patch: fix lock contention for HASHHDR.mutex