Re: pgbench stats per script & other stuff - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: pgbench stats per script & other stuff
Date
Msg-id alpine.DEB.2.10.1601271026150.12620@sto
Whole thread Raw
In response to Re: pgbench stats per script & other stuff  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Hello again,

> Here's part b rebased, pgindented and with some minor additional tweaks
> (mostly function commands and the function renames I mentioned).

Patch looks ok to me, various tests where ok as well.

> Still concerned about the unlocked stat accums.

See my arguments in other mail. I can add a lock if this is a blocker, but 
I think that it is actually better without, because of quantum: the 
measuring process should avoid affecting the measured data, and locking is 
not cheap.

> I haven't tried to rebase the other ones yet, they need manual conflict
> fixes.

Find attached 14-c/d/e rebased patches.

About e, for some obscure reason I failed in my initial attempt at 
inserting the misplaced options in their rightfull position in the option 
list. Sorry for the noise.

-- 
Fabien.

pgsql-hackers by date:

Previous
From: Artur Zakirov
Date:
Subject: Mac OS: invalid byte sequence for encoding "UTF8"
Next
From: "Shulgin, Oleksandr"
Date:
Subject: Trivial doc fix in logicaldecoding.sgml