Re: extend pgbench expressions with functions - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: extend pgbench expressions with functions
Date
Msg-id alpine.DEB.2.10.1511051256500.29177@sto
Whole thread Raw
In response to Re: extend pgbench expressions with functions  (Fabien COELHO <coelho@cri.ensmp.fr>)
List pgsql-hackers
Hello again,

The v14 also remove references to the "threshold" word about gaussian and 
exponential random generation in the source code (comments and variable 
names), as it has no clear meaning, to replace it with param/parameter 
depending on the context, as discussed in another thread started by Tomas 
Vondra.

Sorry for the noise.

> Here is a v13 and a small test script.
>
> - change names to random(), random_exponential() and random_gaussian()
>   I find them too long, but if the committer want that I cannot help
>   it:-)
>
> - more comments, especially about the expression evaluation &
>   type system.
>
> - improved documentation, in particular to include suggestions by Tomas
>   Vondra about clarifying explanations about the gaussian &
>   exponential random generators, and clear references from \setrandom
>   to the \set expressions.
>
> - still just one patch, because removing double would mean removing the 2
>   exponential & gaussian random functions which require a double
>   argument.
>
>   Note that I started with one small patch for adding the infrastructure,
>   but then Heikki requested more functions including double type stuff to
>   illustrate the point, then Robert asks to break it back, going forward
>   and backward is tiring...
>
> - still "lousy" *debug functions, because I found them useful for
>   debugging and testing, really. It is easy to remove them, but I would
>   advise against doing that as it would make debugging an expression
>   much less straightforward.

-- 
Fabien.

pgsql-hackers by date:

Previous
From: Haribabu Kommi
Date:
Subject: Re: [PATCH] Skip ALTER x SET SCHEMA if the schema didn't change
Next
From: Craig Ringer
Date:
Subject: Re: Note about comparation PL/SQL packages and our schema/extensions