Re: pgbench - allow backslash-continuations in custom scripts - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: pgbench - allow backslash-continuations in custom scripts
Date
Msg-id alpine.DEB.2.10.1507031546030.16176@sto
Whole thread Raw
In response to Re: pgbench - allow backslash-continuations in custom scripts  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
> The home-grown lexer is missing e.g. dollar-quoting support, so this is not 
> be parsed correctly:
>
> do $$
> begin
>  ...
> end;
> $$;

> That would be very nice to handle correctly, I've used DO-blocks in pgbench 
> scripts many times, and it's a pain to have to write them in a single line.

Attached is a version which does that (I think), and a test script.
 - backslash-commands can be \-continuated - sql-commands may include $$-quotes and must end with a ';' - double-dash
commentsand blank line are skipped.
 

Obviously it is still a non-lexer hack which can be easily defeated, but 
ISTM that it handles non-contrived cases well. Anyway ISTM that dollar 
quoting cannot be handle as such and simply by a lexer, it is really an 
exception mechanism.

-- 
Fabien.

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [BUGS] BUG #13126: table constraint loses its comment
Next
From: Andrew Dunstan
Date:
Subject: Re: [PATCH] Generalized JSON output functions