Re: pgbench throttling latency limit - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: pgbench throttling latency limit
Date
Msg-id alpine.DEB.2.10.1408261102500.7535@sto
Whole thread Raw
In response to Re: pgbench throttling latency limit  (Rukh Meski <rukh.meski@gmail.com>)
Responses Re: pgbench throttling latency limit
List pgsql-hackers
Hello Rukh,

> I have reviewed this patch.

Thanks!

> [...] I get: pgbench: invalid option -- L
> Which appears to be caused by the fact that the call to getopt_long()
> has not been updated to reflect the new parameter.

Indeed, I only tested/used it with the --limit= syntax.

> Also this part:
> +          "  -L, --limit=NUM          under throttling (--rate), skip
> transactions that\n"
> +          "                           far behind schedule in ms
> (default: do not skip)\n"
> I would suggest rewording this to something like "skip transactions
> that are more than NUM milliseconds behind schedule (default: do not
> skip)".

Done, with milliseconds written as "ms" to keep it short.

> Marking Waiting for Author until these small issues have been fixed.

Please find attached a new version which fixes these two points.

-- 
Fabien.

pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: Proposal for CSN based snapshots
Next
From: Andres Freund
Date:
Subject: Re: replicating DROP commands across servers