Re: Patch to add regression tests for SCHEMA - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: Patch to add regression tests for SCHEMA
Date
Msg-id alpine.DEB.2.02.1306260439490.27845@localhost6.localdomain6
Whole thread Raw
In response to Re: Patch to add regression tests for SCHEMA  (Robins Tharakan <tharakan@gmail.com>)
List pgsql-hackers
> Please find attached an updated patch with the said changes. I'll try to 
> update the other patches (if they pertain to this feedback) and update 
> on their respective threads (as well as on Commitfest).

Ok, this new version addresses my questions.

The patch works for me (nothing to compile, the added tests pass).

I recommend its inclusion as it tests corner cases especially about 
permissions and error conditions, some of which may have security 
implications if they were to fail some day. So this is a good thing.

The above remark applies to all systematic but not redundant regression 
tests submitted. If the overall test was to be deemed too long and slow 
for developers, I would suggest to have a two-tier system with basic and 
fast tests for devs and longer tests for the build farm.

-- 
Fabien.



pgsql-hackers by date:

Previous
From: Mark Wong
Date:
Subject: Re: [Review] Add SPI_gettypmod() to return a field's typemod from a TupleDesc
Next
From: Alvaro Herrera
Date:
Subject: Re: [RFC] Minmax indexes