Re: [PATCH] Make "psql -1 < file.sql" work as with "-f" - Mailing list pgsql-hackers

From Fabien COELHO
Subject Re: [PATCH] Make "psql -1 < file.sql" work as with "-f"
Date
Msg-id alpine.DEB.2.02.1208091756390.16384@localhost6.localdomain6
Whole thread Raw
In response to Re: [PATCH] Make "psql -1 < file.sql" work as with "-f"  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
> OK, done.
>
> I had to revise the original patch pretty heavily before committing;
> the original patch assumed that it was OK to make psql -1 <file go
> through process_file() while having psql -1 <file still go through
> MainLoop() directly.  This isn't a good idea, because that means that
> any other behavioral differences between process_file() and MainLoop()
> will be contingent on whether -1 is used, which is not what we want.

Yep. I did that with a "smallest" and "simplest" change in mind, and 
beside when doing "psql -1 < file", you're hardly going to do anything 
else anyway, so I felt that it was not a big issue.

> And there is at least one such difference that matters: whether or not
> the file and line number get prepended when emitting error messages.

Thanks for the improvements and for the push!

-- 
Fabien.


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Wiki link for max_connections? (Fwd: Re: [ADMIN] PostgreSQL oom_adj postmaster process to -17)
Next
From: Simon Riggs
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Send new protocol keepalive messages to standby servers.