Re: Prevent crash when calling pgstat functions with unregistered stats kind - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Prevent crash when calling pgstat functions with unregistered stats kind
Date
Msg-id akXwVgoofSBd--pG@paquier.xyz
Whole thread
In response to Re: Prevent crash when calling pgstat functions with unregistered stats kind  (Bertrand Drouvot <bertranddrouvot.pg@gmail.com>)
Responses Re: Prevent crash when calling pgstat functions with unregistered stats kind
List pgsql-hackers
On Thu, Jul 02, 2026 at 04:43:32AM +0000, Bertrand Drouvot wrote:
> On Thu, Jul 02, 2026 at 04:23:16AM +0000, Bertrand Drouvot wrote:
>> Ok but what about extensions that don't call pgstat_register_kind() at all? Your
>> point is that they would see the issue during the development of the extension? (If
>> so, I think I could agree).

Extensions doing custom stats have to call the register API, or
they're broken.  This is the same assumption as custom RMGRs.  There
are many ways to break the backend if you don't know what you do, just
take hooks for example.  That's just one of them.

> Something like in the attached?

Yes, that looks OK here.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Alexander Lakhin
Date:
Subject: Re: Improving tracking/processing of buildfarm test failures
Next
From: Bertrand Drouvot
Date:
Subject: Re: Prevent crash when calling pgstat functions with unregistered stats kind