Re: Prevent crash when calling pgstat functions with unregistered stats kind - Mailing list pgsql-hackers

From Bertrand Drouvot
Subject Re: Prevent crash when calling pgstat functions with unregistered stats kind
Date
Msg-id akXw7OIRj6L2eU/V@bdtpg
Whole thread
In response to Re: Prevent crash when calling pgstat functions with unregistered stats kind  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Hi,

On Thu, Jul 02, 2026 at 02:00:06PM +0900, Michael Paquier wrote:
> On Thu, Jul 02, 2026 at 04:43:32AM +0000, Bertrand Drouvot wrote:
> > On Thu, Jul 02, 2026 at 04:23:16AM +0000, Bertrand Drouvot wrote:
> >> Ok but what about extensions that don't call pgstat_register_kind() at all? Your
> >> point is that they would see the issue during the development of the extension? (If
> >> so, I think I could agree).
> 
> Extensions doing custom stats have to call the register API, or
> they're broken.  This is the same assumption as custom RMGRs.  There
> are many ways to break the backend if you don't know what you do, just
> take hooks for example.  That's just one of them.
> 
> > Something like in the attached?
> 
> Yes, that looks OK here.

That makes sense, I do agree.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Prevent crash when calling pgstat functions with unregistered stats kind
Next
From: Palak Chaturvedi
Date:
Subject: Re: Changing the state of data checksums in a running cluster