Re: Redundant/mis-use of _(x) gettext macro? - Mailing list pgsql-hackers

From Álvaro Herrera
Subject Re: Redundant/mis-use of _(x) gettext macro?
Date
Msg-id airjxKXx7aTG8kfE@alvherre.pgsql
Whole thread
In response to Re: Redundant/mis-use of _(x) gettext macro?  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: Redundant/mis-use of _(x) gettext macro?
Re: Redundant/mis-use of _(x) gettext macro?
List pgsql-hackers
On 2026-Apr-24, Peter Smith wrote:

> OK. Including the comma within a larger translated string seems like a
> better idea.
[...]
> Also, why did you choose to implement `last` versus `first` logic?
> e.g. How about this?

In the end I decided to go with the flow and changed to use "first"
logic rather than "last".  I also figured that we should change the
other two places you pointed out at the start of the thread to use the
same coding style.  Since this is mostly cosmetic, I don't feel
compelled to back-patch it, and pushed only to master.

Another place I noticed while looking this over is psql's
describeOneTableDetails(), per the attached patch.  It's essentially
more of the same, but arguably different enough that I judged it
warranted posting before pushing.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/

Attachment

pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: Heads Up: cirrus-ci is shutting down June 1st
Next
From: Salma El-Sayed
Date:
Subject: Re: [GSoC 2026] - B-tree Index Bloat Reduction - Approach & Questions